Eli Mesika has posted comments on this change. Change subject: core : Add Entity API for CoCo commands ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37463/8/packaging/dbscripts/upgrade/03_06_1340_add_cmd_associated_entities_table.sql File packaging/dbscripts/upgrade/03_06_1340_add_cmd_associated_entities_table.sql: Line 1: CREATE TABLE command_assoc_entities ( Line 2: command_id uuid NOT NULL, Line 3: entity_id uuid NOT NULL, Line 4: entity_type character varying(128) Line 5: ); > should be command_id + entity_id @Ravi , please add PK def Line 6: -- To view, visit https://gerrit.ovirt.org/37463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b934ffc44f87407df77c8e097164ca30f3a6e6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
