Moti Asayag has posted comments on this change. Change subject: engine: scheduling host- find free VF ......................................................................
Patch Set 22: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/37931/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 298: Line 299: if (bestHost != null) { Line 300: VfScheduler vfScheduler = Injector.get(VfScheduler.class); Line 301: Map<Guid, String> passthroughVnicToVfMap = vfScheduler.getVnicToVfMap(vm.getId(), bestHost); Line 302: if (passthroughVnicToVfMap != null && !passthroughVnicToVfMap.isEmpty()) { if (MapUtils.isNotEmpty(passthroughVnicToVfMap)) ? Line 303: markVfsAsUsedByVm(bestHost, vm.getId(), passthroughVnicToVfMap); Line 304: } Line 305: } Line 306: https://gerrit.ovirt.org/#/c/37931/22/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3567: Line 3568: @DefaultStringValue("$detailMessage the display network ${DisplayNetwork} must have a DHCP or Static boot protocol when configured on a host") Line 3569: String VAR__DETAIL__DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL(); Line 3570: Line 3571: @DefaultStringValue("$detailMessage there are no free virtual functions which are suitable for virtual nic(s) ${vnicNames}. A virtual function is constidered as suitable if the VF's configuration of its physical function contains the virtual nic's network/network label") since it seems that VF is not clear, perhaps change to: ... no free virtual functions (VFs) is ... Line 3572: String VAR__DETAIL__NO_SUITABLE_VF(); Line 3573: Line 3574: @DefaultStringValue("$detailMessage its CPU level ${hostCPULevel} is lower than the VM requires ${vmCPULevel}") Line 3575: String VAR__DETAIL__LOW_CPU_LEVEL(); -- To view, visit https://gerrit.ovirt.org/37931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
