Simone Tiraboschi has posted comments on this change. Change subject: Adapt to VDSM 3.7 StorageDomainInfo API ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40503/1/src/plugins/ovirt-hosted-engine-setup/storage/storage.py File src/plugins/ovirt-hosted-engine-setup/storage/storage.py: Line 336: domain_info and Line 337: 'remotePath' in domain_info and Line 338: 'type' in domain_info and Line 339: domain_info['type'] in ( Line 340: 'NFS', I'd prefer to modify the value of ohostedcons.VDSMConstants.NFS_DOMAIN or at least add a new constant for that. Line 341: 'GLUSTERFS', Line 342: ) and Line 343: self._removeNFSTrailingSlash( Line 344: domain_info['remotePath'] -- To view, visit https://gerrit.ovirt.org/40503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5f45d088c943c62e0e5761cca1a565616b2dcc5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
