Simone Tiraboschi has posted comments on this change. Change subject: packaging: add provisiondb ......................................................................
Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/40451/8/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 1014: %dir %{engine_data}/setup/ovirt_engine_setup Line 1015: %dir %{engine_data}/setup/plugins Line 1016: %dir %{engine_data}/setup/plugins/ovirt-engine-common Line 1017: %dir %{engine_data}/setup/plugins/ovirt-engine-remove Line 1018: %dir %{engine_data}/setup/plugins/ovirt-engine-setup you probably need something also for %{engine_data}/setup/plugins/ovirt-engine-provisiondb/ Line 1019: %dir %{engine_log}/setup Line 1020: %{_bindir}/engine-cleanup Line 1021: %{_bindir}/engine-setup Line 1022: %{_mandir}/man8/engine-cleanup.* https://gerrit.ovirt.org/#/c/40451/8/packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py File packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py: Line 76: def _init(self): Line 77: self.environment[ Line 78: osetupcons.CoreEnv.ACTION Line 79: ] = osetupcons.Const.ACTION_PROVISIONDB Line 80: self.environment.setdefault( isn't already done in packaging/setup/plugins/ovirt-engine-common/base/core/misc.py? Line 81: osetupcons.CoreEnv.DEVELOPER_MODE, Line 82: None Line 83: ) Line 84: self.logger.debug( Line 88: osetupcons.Const.DISPLAY_VERSION, Line 89: ) Line 90: self.environment[ Line 91: osetupcons.CoreEnv.SETUP_ATTRS_MODULES Line 92: ] = [osetupcons] same Line 93: self.environment.setdefault( Line 94: oengcommcons.SystemEnv.USER_POSTGRES, Line 95: oengcommcons.Defaults.DEFAULT_SYSTEM_USER_POSTGRES Line 96: ) Line 95: oengcommcons.Defaults.DEFAULT_SYSTEM_USER_POSTGRES Line 96: ) Line 97: self.environment.setdefault( Line 98: osetupcons.CoreEnv.UNINSTALL_UNREMOVABLE_FILES, Line 99: [] here too Line 100: ) Line 101: Line 102: @plugin.event( Line 103: stage=plugin.Stages.STAGE_CLEANUP, https://gerrit.ovirt.org/#/c/40451/8/packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/offlinepackager.py File packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/offlinepackager.py: Line 35: Line 36: Line 37: @util.export Line 38: class Plugin(plugin.PluginBase, packager.PackagerBase): Line 39: """Offline packager.""" Why do you need to copy/move it from packaging/setup/plugins/ovirt-engine-common/base/core/offlinepackager.py Line 40: def install(self, packages, ignoreErrors=False): Line 41: pass Line 42: Line 43: def update(self, packages, ignoreErrors=False): -- To view, visit https://gerrit.ovirt.org/40451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02a141f2933b208375127cad156547350c41dd2b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
