Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: UI plugin revealPlace API - rename parameter ......................................................................
webadmin: UI plugin revealPlace API - rename parameter Renamed placeToken to historyToken for consistency with existing APIs such as addMainTab & addSubTab. No impact on revealPlace API implementation. Change-Id: I073f51acb95438fbccf1f0c58796a885a44c1a50 Bug-Url: https://bugzilla.redhat.com/1168334 Signed-off-by: Vojtech Szocs <vsz...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/40494/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java index 05790f1..44ebf07 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java @@ -508,9 +508,9 @@ uifunctio...@org.ovirt.engine.ui.webadmin.plugin.api.PluginUiFunctions::closeDialog(Ljava/lang/String;)(dialogToken); } }, - revealPlace: function(placeToken) { + revealPlace: function(historyToken) { if (canDoPluginAction(this.pluginName)) { - uifunctio...@org.ovirt.engine.ui.webadmin.plugin.api.PluginUiFunctions::revealPlace(Ljava/lang/String;)(placeToken); + uifunctio...@org.ovirt.engine.ui.webadmin.plugin.api.PluginUiFunctions::revealPlace(Ljava/lang/String;)(historyToken); } }, setSearchString: function(searchString) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java index ae34c66..7271fda 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java @@ -245,13 +245,13 @@ } /** - * Reveals the given application place. + * Reveals the application place denoted by {@code historyToken}. */ - public void revealPlace(final String placeToken) { + public void revealPlace(final String historyToken) { Scheduler.get().scheduleDeferred(new ScheduledCommand() { @Override public void execute() { - placeManager.revealPlace(new PlaceRequest.Builder().nameToken(placeToken).build()); + placeManager.revealPlace(new PlaceRequest.Builder().nameToken(historyToken).build()); } }); } -- To view, visit https://gerrit.ovirt.org/40494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I073f51acb95438fbccf1f0c58796a885a44c1a50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
