Ramesh N has posted comments on this change. Change subject: webadmin : geo-rep status detail pop up ......................................................................
Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/32100/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 1622: getGlusterVolumeBrickById Currently this is not used. May be u can remove this or you could change this to accept multiple brick IDs here and run cal runMultipleQuery here itself. https://gerrit.ovirt.org/#/c/32100/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 308: for (VdcQueryReturnValue returnValue : result.getReturnValues()) { : for (GlusterGeoRepSessionDetails sessionDetail : details) { You Could avoid this nested loop by iterating over index. Entries in the result.getReturnValues will be in the same order of the queryParameter. Line 316: if(detailRows.size() == details.size()) When this will be false? Do we need to do something if it is false? -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
