Yedidyah Bar David has posted comments on this change. Change subject: support .repo overrides ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/39534/17/ovirt-release-master/ovirt-release-master.spec.in File ovirt-release-master/ovirt-release-master.spec.in: Line 80: fi Line 81: Line 82: if [[ "${DISTVER}" == "el6" ]]; then Line 83: install -m 644 "%{_datadir}/%{package_name}/ovirt-el6-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" Line 84: elif [[ "${DISTVER/.*/}" =~ ^el7 ]]; then > tested with sh, bash, zsh and ksh. What's 'sh'? I'd check also with 'posh' and 'ash/dash'. Some time ago there was a discussion about replacing fedora's default /bin/sh, not sure about the outcome. Line 85: # On CentOS 7 ${DISTVER} is "el7.centos" Line 86: install -m 644 "%{_datadir}/%{package_name}/ovirt-el7-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" Line 87: elif [[ "${DISTVER}" == "fc20" ]]; then Line 88: install -m 644 "%{_datadir}/%{package_name}/ovirt-f20-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" -- To view, visit https://gerrit.ovirt.org/39534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0453fb472d80a190278a0ffbae4371ad724b4c46 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
