Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: pki: renew about to expire certificates ......................................................................
Patch Set 3: Code-Review+1 (2 comments) Any chance to put some/most of the added functions in lib, to allow using them also in other plugins? IOW, you did most of the work for https://bugzilla.redhat.com/show_bug.cgi?id=1133421 , why not finish it :-) ? (Or at least make this patch useful for it too) https://gerrit.ovirt.org/#/c/40330/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py: Line 254: 'certificate is an internal certificate' Line 255: ) Line 256: Line 257: # sanity check, make sure user did not manually Line 258: # chang cert change Line 259: x509x = X509.load_cert( Line 260: os.path.join( Line 261: ( Line 262: oenginecons.FileLocations. Line 383: ) Line 384: def _miscUpgrade(self): Line 385: # Line 386: # In <3.6 setup did not store the organization and Line 387: # country in post install file. Load it from CA certifcate. certificate Line 388: # Line 389: if self.environment[oenginecons.PKIEnv.ORG] is None: Line 390: ca = X509.load_cert( Line 391: oenginecons.FileLocations. -- To view, visit https://gerrit.ovirt.org/40330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6383b29e131d65cece96e298bb2c7fe6ae305afe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
