Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Add SSO UI for Changing expired user passwd
......................................................................


Patch Set 2:

(1 comment)

oh... waiting for the "backend code"

the welcome and the login page should contain a link to change password, so 
user can change password even if not expired.

https://gerrit.ovirt.org/#/c/40445/2/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginChangePasswdServlet.java
File 
backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginChangePasswdServlet.java:

Line 33:             if (SSOUtils.isUserAuthenticated(session)) {
Line 34:                 changeUserPasswd(request);
Line 35:             }
Line 36:         } catch (AuthenticationException ex) {
Line 37:             log.error("Password Change failed", ex.getMessage());
.

 "Change password for user '{}' failed: {}"
Line 38:             log.debug("Password Change failed", ex);
Line 39:             request.getSession(true).setAttribute(SSOUtils.LOGIN_MSG, 
ex.getMessage());
Line 40:             response.sendRedirect(request.getContextPath() + 
SSOUtils.PASSWORD_CHANGE_FORM_URI);
Line 41:         } finally {


-- 
To view, visit https://gerrit.ovirt.org/40445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9923114954737ea49b8ccd3d8ee69072cb5e01d9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to