Alon Bar-Lev has posted comments on this change. Change subject: aaa: Remove Authn from backend ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/40154/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java: we can probably remove this class in favor of interaction directly with the extensions manager, no? Line 1: package org.ovirt.engine.core.aaa; Line 2: Line 3: import org.ovirt.engine.api.extensions.Base; Line 4: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; https://gerrit.ovirt.org/#/c/40154/3/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LogoutServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LogoutServlet.java: squash to sso servlet? (first patch)? Line 1: package org.ovirt.engine.core.sso.servlets; Line 2: Line 3: import org.apache.commons.lang.StringUtils; Line 4: import org.ovirt.engine.api.extensions.Base; https://gerrit.ovirt.org/#/c/40154/3/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java: Line 39: Line 40: ctx.setAttribute(SSOUtils.SSO_CONFIG, config); Line 41: Line 42: config.setSsoProfiles(AuthenticationUtils.getAvailableProfiles(ctx)); Line 43: config.setSsoProfilesSupportingPasswd(AuthenticationUtils.getAvailableProfilesSupportingPasswd(ctx)); should be squashed to first patch (sso patch). Line 44: config.setWelcomeUrl(localConfig.getProperty(WELCOME_URL)); Line 45: config.setAcceptBasicAuthHeaders(localConfig.getBoolean(ACCEPT_BASIC_AUTH_HEADERS)); Line 46: config.setAllowDisableExternalAuth(localConfig.getBoolean(ALLOW_DISABLE_EXTERNAL_AUTH)); Line 47: config.setEnableBasicAuth(localConfig.getBoolean(ENABLE_BASIC_AUTH)); https://gerrit.ovirt.org/#/c/40154/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: we should also add a mask of required services to load, so that if we have authn within extensions.d then it will not be initialized using this instance. Line 1: package org.ovirt.engine.core.utils.extensionsmgr; Line 2: Line 3: import static java.util.Arrays.sort; Line 4: -- To view, visit https://gerrit.ovirt.org/40154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie97dbdb8540b26cd8b53f8c373970361ddec4d6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
