Alon Bar-Lev has posted comments on this change. Change subject: aaa: Add support for rest api Basic auth ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/37786/10/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiLoginFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiLoginFilter.java: Line 137: httpSession.setAttribute( Line 138: SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY, Line 139: queryRetVal.getActionReturnValue()); Line 140: } catch (Exception ex) { Line 141: log.error("Exception creating user session {}", ex.getMessage()); . "User '{}' login failed: {}" Line 142: log.error("exception", ex); Line 143: } finally { Line 144: try { Line 145: if (ctx != null) { https://gerrit.ovirt.org/#/c/37786/10/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginCredentialsServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginCredentialsServlet.java: Line 35: os.write(SSOUtils.issueTicket(request.getSession(true), request).getBytes("UTF-8")); Line 36: } Line 37: } Line 38: } catch (Exception e) { Line 39: log.error("Unable to authenticate {}", e.getMessage()); . "User '{}' authentication failed: {}" in all these places, if you do not have credentials you can print a general error or something similar. Line 40: log.debug("Unable to authenticate", e); Line 41: response.sendError(HttpServletResponse.SC_UNAUTHORIZED); Line 42: } Line 43: } -- To view, visit https://gerrit.ovirt.org/37786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f6975f2d306a4dc2d81b795ab4905e5d3281a1 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
