Dudi Maroshi has posted comments on this change. Change subject: webadmin: Added range values to QoS error message. ......................................................................
Patch Set 8: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/35318/8/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1009: ACTION_TYPE_NON_MONITORED=Cannot ${action} ${type}. Non monitored command. Line 1010: Line 1011: # QoS errors Line 1012: QOS_CPU_SHARES_OUT_OF_RANGE=Cannot set the cpu shares to the requested value. It has to be between 0 and 262144. Line 1013: ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range\n(Legal range is: ${range}). I do not know how the REST api handles the \n (newline). In the error message. Please consult with Juan juan.hernan...@redhat.com about inserting newlines. Line 1014: Line 1015: # Alignment scan Line 1016: ERROR_CANNOT_RUN_ALIGNMENT_SCAN_VM_IS_RUNNING=Cannot ${action} ${type}. Alignment scan of a disk attached to a running VM is only supported with RAW virtual disks. Line 1017: ACTION_TYPE_FAILED_ALIGNMENT_SCAN_STORAGE_TYPE=Cannot ${action} ${type}. Alignment scan is only supported for disks located on block storage domains. -- To view, visit https://gerrit.ovirt.org/35318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e1b2ef97624b6b0f3c9c95e7a09e15561a458b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
