Moti Asayag has posted comments on this change. Change subject: core: Upgrade message in general tab is missing ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37849/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java: Line 114: Line 115: // Review the alerts and add those that are active: Line 116: if (model.getHasUpgradeAlert()) { Line 117: if (model.getEntity().getStatus() == VDSStatus.Maintenance) { Line 118: addTextAlert(view, messages.hostInMaintenanceHasUpgradeAlert()); while the message says: "If you wish to upgrade or reinstall the host click here" there is actually no click-able link in this context. There should have been use of addTextAndLinkAlert, i.e. addTextAndLinkAlert(view, msg, relevant_command); Line 119: } Line 120: else { Line 121: addTextAlert(view, messages.hostHasUpgradeAlert()); Line 122: } -- To view, visit https://gerrit.ovirt.org/37849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5af3adca237609dfa696828caa39919c7e4da82b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
