Maor Lipchuk has uploaded a new change for review.
Change subject: core: Adding error log for image validation.
......................................................................
core: Adding error log for image validation.
Adding error log to indicate more details about the disk and Storage Domain
which could not be found to validate disk once importing an unregistered
VM.
Change-Id: I9b1787641622b6d430b8b06775a335b912a7798f
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/40465/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
index 15e032a..08a5c41 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
@@ -32,6 +32,8 @@
import org.ovirt.engine.core.dal.dbbroker.DbFacade;
import org.ovirt.engine.core.dao.StorageDomainDAO;
import org.ovirt.engine.core.dao.StoragePoolDAO;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class ImportValidator {
@@ -46,6 +48,8 @@
public ImportValidator(ImportVmParameters params) {
this.params = params;
}
+
+ protected Logger log = LoggerFactory.getLogger(getClass());
/**
* Used for testings
@@ -67,6 +71,11 @@
image.getStorageIds().get(0), getStoragePool().getId());
ValidationResult result = new
StorageDomainValidator(sd).isDomainExistAndActive();
if (!result.isValid()) {
+ log.error("Storage Domain '{}' with id '{}', could not be
found for image name '{}' with image id '{}'",
+ sd == null ? null : sd.getStorageName(),
+ image.getStorageIds().get(0),
+ image.getDiskAlias(),
+ image.getId());
return result;
}
}
--
To view, visit https://gerrit.ovirt.org/40465
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b1787641622b6d430b8b06775a335b912a7798f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
