Martin Betak has posted comments on this change. Change subject: frontend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/33376/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java: Line 30: private String clientIp; Line 31: private String consoleUserName; Line 32: Line 33: public VmGuestInfoModel() { Line 34: super(); Explicit call to super(); is redundant. Line 35: Line 36: setTitle(ConstantsManager.getInstance().getConstants().sessionsTitle()); Line 37: setHelpTag(HelpTag.guest_info); Line 38: setHashName("guest_info"); //$NON-NLS-1$ Line 38: setHashName("guest_info"); //$NON-NLS-1$ Line 39: Line 40: guestOsType = OsType.Other; Line 41: guestOsArch = ArchitectureType.undefined; Line 42: guestOsCodename = ""; It makes me wonder if CheckStyle doesn't require those //$NON-NLS-1$ even on empty strings. But if jenkins doesn't fail on it, please feel free to keep it this way :-) Line 43: guestOsDistribution = ""; Line 44: guestOsKernelVersion = ""; Line 45: guestOsVersion = ""; Line 46: guestOs = ""; -- To view, visit https://gerrit.ovirt.org/33376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7f9ae95b2b9fe9affa27886a7981bcdffabee49 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
