Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI plugin API - setSearchString ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40405/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java: Line 673: model.setCaseSensitiveSearch(false); Line 674: Line 675: // ListModel.setSelectedItem compares values by reference, following code ensures that Line 676: // "model" will always be selected (even if it's already the currently selected item) Line 677: selectedItem = null; Note to reviewers: without this, following scenario would be broken: * click on Hosts main tab * click on custom main tab * execute in custom main tab: api.setSearchString('Hosts: name = abc'); * nothing happens, because CommonModel thinks Hosts main tab is still selected (CommonModel's selected item doesn't change, so place transition to Hosts main tab doesn't happen at all.) This should not affect existing behavior in any way. Line 678: Line 679: // Change active list model as neccesary. Line 680: setSelectedItem(model); Line 681: -- To view, visit https://gerrit.ovirt.org/40405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36eb8647577e974bddefe9462d302165a39b1c27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
