Lior Vernia has posted comments on this change. Change subject: engine: Truncate percentage in case NIC speed is too low ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37752/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1034: /** Line 1035: * TODO: only needed if rate reported by vdsm (in which case can't be null) - remove in 4.0 and turn Line 1036: * NetworkStatisticsBuilder.truncatePercentage() private Line 1037: */ Line 1038: if (!totalStatsReported) { > Shouldn't it be- if (totalStatsReported) ? No. If *total* statistics are reported by vdsm, then *rate* is computed by the engine (instead of being taken from vdsm). This piece of code only handles truncation of vdms-reported rate - engine-computed rate is already truncated within NetworkStatisticsBuilder. Line 1039: receiveRate = NetworkStatisticsBuilder.truncatePercentage(receiveRate); Line 1040: transmitRate = NetworkStatisticsBuilder.truncatePercentage(transmitRate); Line 1041: } Line 1042: -- To view, visit https://gerrit.ovirt.org/37752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83bd4d642e93af312d65fefc4417eeccc88bc9dc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
