Allon Mureinik has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 37: (1 comment) I see the change for BackendStorageDomain[s]ResourceTest, but no change for the corresponding production code. Is this intentional? https://gerrit.ovirt.org/#/c/35277/37/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java: Line 119: entity.setStorageFormat(StorageFormatType.forValue(rs Line 120: .getString("storage_domain_format_type"))); Line 121: entity.setLastTimeUsedAsMaster(rs.getLong("last_time_used_as_master")); Line 122: entity.setWipeAfterDelete(rs.getBoolean("wipe_after_delete")); Line 123: entity.setWarningLowSpaceIndicator(rs.getInt("warning_low_space_indicator")); If this can be null in the DB (AFAIK, it can), you should use (Integer) rs.getObject("column_name") Line 124: entity.setCriticalSpaceActionBlocker(rs.getInt("critical_space_action_blocker")); Line 125: return entity; Line 126: } Line 127: } -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
