Omer Frenkel has posted comments on this change. Change subject: core: VirtIO console access key management ......................................................................
Patch Set 14: (3 comments) https://gerrit.ovirt.org/#/c/39512/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java: Line 36: Line 37: if (sshPublicKey == null || sshPublicKey.isEmpty()) { Line 38: // the user wants to wipe out its own key, and we're fine with that. Line 39: log.info("Provided {} SSH key for user '{}'", Line 40: (sshPublicKey == null) ?"null" :"empty", there is no real reason to log this, i think, since there is a log for commands execution and also audit logs if you really like to keep this (and the others below) please change to debug Line 41: getUserId().toString()); Line 42: return true; Line 43: } Line 44: Line 53: } Line 54: Line 55: @Override Line 56: public List<PermissionSubject> getPermissionCheckSubjects() { Line 57: return Collections.singletonList(new PermissionSubject(getUserId(), VdcObjectType.System, ActionGroup.EDIT_PROFILE)); sorry i missed that before, you should send "getActionType().getActionGroup()" instead of specifying the actionGroup here, and specify the correct action group in VdcActionType enum (where currently it is wrongly MANIPULATE_USERS it should be the new EDIT_PROFILE Line 58: } https://gerrit.ovirt.org/#/c/39512/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 184: AddUser(419, ActionGroup.MANIPULATE_USERS, false, QuotaDependency.NONE), Line 185: AddGroup(420, ActionGroup.MANIPULATE_USERS, false, QuotaDependency.NONE), Line 186: AddUserProfile(421, ActionGroup.MANIPULATE_USERS, false, QuotaDependency.NONE), Line 187: UpdateUserProfile(422, ActionGroup.MANIPULATE_USERS, false, QuotaDependency.NONE), Line 188: RemoveUserProfile(423, ActionGroup.MANIPULATE_USERS, false, QuotaDependency.NONE), all should be EDIT_PROFILE Line 189: // Tags Line 190: AddTag(501, false, QuotaDependency.NONE), Line 191: RemoveTag(502, false, QuotaDependency.NONE), Line 192: UpdateTag(503, false, QuotaDependency.NONE), -- To view, visit https://gerrit.ovirt.org/39512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ff5403823e752e695ebde76a4b7fb83e07099b6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
