Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Modified to disable the new snapshot creation ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/40118/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java: Line 204: brick.getStatus() == GlusterStatus.DOWN > 1. You may need to disable when brick status is UNKNOWN. So brick.isOnline( 1. done 2. Snapshot creation has a flag force which is currently false by default. If the same is passed as true, gluster would take snapshot if quorum is met. As there are some issues currently with force option so I expect all the bricks to be online for the time being. https://gerrit.ovirt.org/#/c/40118/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 583: > may be we could avoid this in a subsequent refactoring patch. Sure Line 591: (list.get(0).getStatus() == GlusterStatus.UP > This can be as part of if in the top itself. U will not loop over all the b Done -- To view, visit https://gerrit.ovirt.org/40118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
