Omer Frenkel has posted comments on this change. Change subject: engine: calling CollectVdsNetworkData after vm state changed to up ......................................................................
Patch Set 27: (1 comment) small comment https://gerrit.ovirt.org/#/c/38261/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java: Line 79: List<VmDevice> vfs = vmDeviceDao.getVmDeviceByVmIdTypeAndDevice(vmId, Line 80: VmDeviceGeneralType.INTERFACE, Line 81: VmDeviceType.HOST_DEVICE.getName()); Line 82: Line 83: return !vfs.isEmpty() || vmDeviceDao.existsVmDeviceByVmIdAndType(vmId, VmDeviceGeneralType.HOSTDEV); why not reuse and call checkVmNeedsDirectPassthroug(vmId) ? Line 84: } Line 85: Line 86: public boolean checkVmHostDeviceAvailability(VM vm, Guid vdsId) { Line 87: // if vm's cluster doesn't support hostdev, it's requirements for host devices are trivially fulfilled -- To view, visit https://gerrit.ovirt.org/38261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
