Sandro Bonazzola has posted comments on this change. Change subject: glusterfs: add support for glusterfs 3.7 ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39600/2/src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py File src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py: Line 215: def _setup(self): Line 216: if self.services.exists(ohostedcons.Const.GLUSTERFSD_SERVICE): Line 217: # glusterfsd is not provided in glusterfs-server >= 3.7 Line 218: self._gluster_services.append( Line 219: ohostedcons.Const.GLUSTERFSD_SERVICE > AFAIK, we only need to start glusterd service even prior to 3.7. So dropping glusterfsd service at all? Line 220: ) Line 221: Line 222: @plugin.event( Line 223: stage=plugin.Stages.STAGE_CUSTOMIZATION, -- To view, visit https://gerrit.ovirt.org/39600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31970924b7a9a7a59a2c44962d353f6586aec8cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
