Oved Ourfali has posted comments on this change. Change subject: webadmin: GuideMe can't activate hosts ......................................................................
Patch Set 2: (2 comments) Seems okay overall. Requires ack from Alexander, once you address some of his comments. https://gerrit.ovirt.org/#/c/39992/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java: Line 158: } Line 159: }; Line 160: Line 161: // Execute the timer to expire 5 seconds in the future Line 162: timer.schedule(5000); > We are waiting for VdsActivate command to succeeded. So we wait 5 second an What happens if it isn't "up" in 5 seconds? Line 163: } Line 164: }, Line 165: this); Line 166: } https://gerrit.ovirt.org/#/c/39992/2/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 2236: (); so if not finished in 5 seconds, this will be printed? Sounds good. -- To view, visit https://gerrit.ovirt.org/39992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983ad2c714ff945541de5f0b0d6f95e524f7edbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
