Ondřej Macháček has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40157/4/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 110: ); Line 111: } Line 112: if (value == null && parserArgument.getValue() != null) { Line 113: value = parserArgument.getValue(); Line 114: } > actually it can be reduced to: true:) Line 115: Object convertedValue = null; Line 116: if (value != null) { Line 117: Matcher m = parserArgument.getMatcher().matcher(value); Line 118: if (!m.find()) { -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
