Alon Bar-Lev has posted comments on this change. Change subject: manage domains: convert to new parameters parser ......................................................................
Patch Set 8: (1 comment) looks good! https://gerrit.ovirt.org/#/c/39972/8/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java: Line 99: System.exit(1); Line 100: } Line 101: } Line 102: Line 103: private static void setupLogger(Map<String, Object> args) { missing environment default at initialization point. Line 104: if (args.containsKey("log-file")) { Line 105: JavaLoggingUtils.addFileHandler((String)args.get("log-file")); Line 106: } Line 107: if (args.containsKey("log-level")) { -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
