Martin Mucha has posted comments on this change. Change subject: restapi: Add setupnetworks api ......................................................................
Patch Set 17: (7 comments) https://gerrit.ovirt.org/#/c/35379/17/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 2635: request: Line 2636: body: Line 2637: parameterType: Action Line 2638: signatures: Line 2639: - mandatoryArguments: {} how about this? This also seems not needed. Is it? Line 2640: optionalArguments: Line 2641: action.network_attachments.network_attachment--COLLECTION: Line 2642: network_attachment.id: 'xs:string' Line 2643: network_attachment.network.name|id: 'xs:string' Line 2637: parameterType: Action Line 2638: signatures: Line 2639: - mandatoryArguments: {} Line 2640: optionalArguments: Line 2641: action.network_attachments.network_attachment--COLLECTION: > Avoid quotes around "xs:..." Done Line 2642: network_attachment.id: 'xs:string' Line 2643: network_attachment.network.name|id: 'xs:string' Line 2644: network_attachment.host_nic.name|id: 'xs:string' Line 2645: network_attachment.ip_configuration.ipv4s.boot_protocol: 'xs:string' Line 2641: action.network_attachments.network_attachment--COLLECTION: Line 2642: network_attachment.id: 'xs:string' Line 2643: network_attachment.network.name|id: 'xs:string' Line 2644: network_attachment.host_nic.name|id: 'xs:string' Line 2645: network_attachment.ip_configuration.ipv4s.boot_protocol: 'xs:string' > I think that it should be "ips" instead of "ipv4s". Done Line 2646: network_attachment.ip_configuration.ipv4s.ipv4--COLLECTION: Line 2647: ipv4.address: 'xs:string' Line 2648: ipv4.netmask: 'xs:string' Line 2649: ipv4.gateway: 'xs:string' Line 2650: network_attachment.properties.property--COLLECTION: Line 2651: property.name: 'xs:string' Line 2652: property.value: 'xs:string' Line 2653: network_attachment.override_configuration: 'xs:boolean' Line 2654: action.removed_network_attachments.network_attachment--COLLECTION: {network_attachment.id: 'xs:string'} > Try to use indentation instead of curly braces. Done Line 2655: action.bonds.host_nic--COLLECTION: Line 2656: host_nic.name|id: 'xs:string' Line 2657: host_nic.bonding.options.option--COLLECTION: Line 2658: option.name: 'xs:string' Line 2659: option.value: 'xs:string' Line 2660: option.type: 'xs:string' Line 2661: bonding.slaves.host_nic--COLLECTION: {host_nic.name|id: 'xs:string'} Line 2662: action.removed_bonds.host_nic--COLLECTION: {host_nic.name|id: 'xs:string'} Line 2663: action.checkConnectivity: 'xs:boolean' > Should be "check_connectivity". Done Line 2664: action.connectivityTimeout: 'xs:int' Line 2665: action.async: 'xs:boolean' Line 2666: action.grace_period.expiry: 'xs:long' Line 2667: description: initiate the command to setup networks for the specified host Line 2660: option.type: 'xs:string' Line 2661: bonding.slaves.host_nic--COLLECTION: {host_nic.name|id: 'xs:string'} Line 2662: action.removed_bonds.host_nic--COLLECTION: {host_nic.name|id: 'xs:string'} Line 2663: action.checkConnectivity: 'xs:boolean' Line 2664: action.connectivityTimeout: 'xs:int' > Should be "connectivity_timeout". Done Line 2665: action.async: 'xs:boolean' Line 2666: action.grace_period.expiry: 'xs:long' Line 2667: description: initiate the command to setup networks for the specified host Line 2668: - name: /hosts/{host:id}/nics/{nic:id}/networkattachments|rel=get Line 2662: action.removed_bonds.host_nic--COLLECTION: {host_nic.name|id: 'xs:string'} Line 2663: action.checkConnectivity: 'xs:boolean' Line 2664: action.connectivityTimeout: 'xs:int' Line 2665: action.async: 'xs:boolean' Line 2666: action.grace_period.expiry: 'xs:long' > Remove the "async" and "grace_period" parameters, they are added implicitly Done Line 2667: description: initiate the command to setup networks for the specified host Line 2668: - name: /hosts/{host:id}/nics/{nic:id}/networkattachments|rel=get Line 2669: description: get the list of network attachments of the network interface Line 2670: request: -- To view, visit https://gerrit.ovirt.org/35379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f6004956a6b0f17ef5242eb5021429949f65fe Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
