Martin Betak has posted comments on this change. Change subject: webadmin: improve error checking on import dialog ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40310/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java: Line 615: return true; Line 616: } Line 617: Line 618: @SuppressWarnings("unchecked") Line 619: public void setItems(final Collection value, final Guid storageDomainId) { > well.. I can propagate it to setItems' signature, but not on level up (Impo I prefer to have as much code using generic (instead of raw types) as possible and have the casts/raw types localized into one place if possible. Note: I remember the TemplateBackupModel extending VmBackupModel issue from my previous frontend refactoring attempts (to introduce generics into all models). I remember having tried introducing a generic VmBaseBackupModel<T> that was extended by VmBackupModel and TemplateBackupModel. Sadly I had to abandon this because the patch in qustion has gotten already too big. This was obviously before you started implementing this feature. Note to me: It may be worth to revisit this issue after this new "Import" feature is finalized. Line 620: Frontend.getInstance().runQuery(VdcQueryType.Search, Line 621: new SearchParameters(createSearchPattern(value), SearchType.VM), Line 622: new AsyncQuery(this, new INewAsyncCallback() { Line 623: -- To view, visit https://gerrit.ovirt.org/40310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
