Roy Golan has posted comments on this change. Change subject: core: break down spaghetti-code in VdsSelector ......................................................................
Patch Set 1: +1 for interfacing small validation checks - I think this is worthy for your future work for plug-able checks? -1 for using ValidationResult and returning null - I think there is no good reason to wrap VdcBllMessage. the gap between VdcBllMessage and ValidationResault is the VALID member which is == to Unassigned can you try to simplify this using VdcBllMessages? -- To view, visit http://gerrit.ovirt.org/8401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b4535e050790434b12180fc0bae55dd26fe43b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches