Alona Kaplan has posted comments on this change. Change subject: webadmin: edit panel for sriov enabled nics ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/36259/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostNicPopupPresenterWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostNicPopupPresenterWidget.java: Line 24: @Override Line 25: public void init(HostNicModel model) { Line 26: super.init(model); Line 27: Line 28: if (model.getVfsConfigModel() != null) { > Would be nicer to have a boolean method HostNicModel.hasVfs() and hide this Done Line 29: if (model.getInterface().getBondName() == null) { Line 30: // sriov nic Line 31: getView().showTabs(); Line 32: } else { Line 25: public void init(HostNicModel model) { Line 26: super.init(model); Line 27: Line 28: if (model.getVfsConfigModel() != null) { Line 29: if (model.getInterface().getBondName() == null) { > It's better to invoke model.getInterface().isBondSlave() (and probably swit Done Line 30: // sriov nic Line 31: getView().showTabs(); Line 32: } else { Line 33: // sriov bond slave https://gerrit.ovirt.org/#/c/36259/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java: Line 86: Line 87: @Override Line 88: protected void populateTabMap() { Line 89: getTabNameMapping().put(TabName.PF_TAB, this.pfTab); Line 90: getTabNameMapping().put(TabName.VFS_CONFIG_TAB, this.vfsConfigTab); > You could get rid of the "this". Done Line 91: } Line 92: Line 93: @Override Line 94: public void showTabs() { -- To view, visit https://gerrit.ovirt.org/36259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72f82871b3ea7a90ec68d2779c4e835cdac2c692 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
