Alona Kaplan has posted comments on this change. Change subject: engine: Cleanup the vfs when the vm is down and refresh host if needed ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/38624/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java: Line 131: Line 132: movedToDownVmIds.add(vm.getId()); Line 133: } Line 134: Line 135: if (!movedToDownVmIds.isEmpty()) { > for the sake of consistency, either remove this if-check (is there a reason I need it here because the tests fail without it. So I whether had to mock hostDeviceManager in the tests or adding this 'if', adding the 'if' was easier:) If you insist I can add add to all the other places, but IMO it is redundant. Line 136: HostDeviceManager hostDeviceManager = Injector.get(HostDeviceManager.class); Line 137: hostDeviceManager.refreshHostIfAnyVmHasHostDevices(movedToDownVmIds, vds.getId()); Line 138: } Line 139: -- To view, visit https://gerrit.ovirt.org/38624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f861a451f4e0961ec122e4c2594081ea6dc71b Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
