Alona Kaplan has posted comments on this change. Change subject: engine: calling CollectVdsNetworkData after vm state changed to up ......................................................................
Patch Set 24: (1 comment) https://gerrit.ovirt.org/#/c/38261/24/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 248: Line 249: refreshHostIfAnyVmHasHostDevices(succeededToRunVms); Line 250: } Line 251: Line 252: private void refreshHostIfAnyVmHasHostDevices(final List<Guid> vmIds) { > how about moving the whole method to VdsEventListener? VdsEventListener already have refreshHostIfAnyVmHasHostDevices method. Most of the calls except this one to getVdsEventListener().refreshHostIfAnyVmHasHostDevices don't need opening a new thread. I can add a 'runInNewThread' parameter to the method, but I think it is less readable. Line 253: if (vmIds.isEmpty()) { Line 254: return; Line 255: } Line 256: -- To view, visit https://gerrit.ovirt.org/38261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
