Juan Hernandez has posted comments on this change. Change subject: reformat all pom.xml files ......................................................................
Patch Set 1: (2 comments) As far as I can see this change corrects indentation in many places, but it also remove empty lines used to separate sections of the files and make them more readable. The first is ok, but the second isn't. https://gerrit.ovirt.org/#/c/40336/1/backend/manager/dependencies/common/pom.xml File backend/manager/dependencies/common/pom.xml: Line 278: Line 279: https://java.net/jira/browse/JAXB-860 Line 280: Line 281: It can be removed once we update to WildFly 8, as it uses Line 282: version 2.2.5, where the bug is fixed. --> This was correctly indented before the change, but it isn't now. Line 283: <dependency> Line 284: <groupId>com.sun.xml.bind</groupId> Line 285: <artifactId>jaxb-core</artifactId> Line 286: <version>${jaxb-impl.version}</version> Line 301: https://bugzilla.redhat.com/1064231 Line 302: Line 303: Note that won't be fixed by WildFly, as it includes version Line 304: 2.x of Jackson, which won't probably be supported by the Line 305: OpenStack Java SDK. --> Same. Line 306: <dependency> Line 307: <groupId>org.codehaus.jackson</groupId> Line 308: <artifactId>jackson-core-asl</artifactId> Line 309: <version>${jackson.version}</version> -- To view, visit https://gerrit.ovirt.org/40336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b09be7d4ff7ced323cf1894280037edee87638a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Max Kovgan <m...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: eyal edri <eyal.e...@gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
