Alon Bar-Lev has posted comments on this change.

Change subject: packaging: open up firewall rules for console and migration in 
aio mode
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File packaging/fedora/setup/engine-setup.py
Line 922:                         portCfg["port"]
Line 923:                     )
Line 924:                 )
Line 925: 
Line 926:         if 'EXTRA_IPTABLES_RULES' in controller.CONF:
Done
Line 927:             lines += controller.CONF['EXTRA_IPTABLES_RULES']
Line 928: 
Line 929:         outputText = fileContent.replace('@CUSTOM_RULES@', 
"\n".join(lines))
Line 930:         logging.debug(outputText)


....................................................
File packaging/fedora/setup/plugins/all_in_one_100.py
Line 198: 
Line 199:     if 'EXTRA_IPTABLES_RULES' not in controller.CONF:
Line 200:         controller.CONF['EXTRA_IPTABLES_RULES'] = []
Line 201: 
Line 202:     controller.CONF['EXTRA_IPTABLES_RULES'] += [
guest console and migration... there are comments.

I must say I don't understand why migration is needed...
Line 203:         '#guest consoles',
Line 204:         '-A INPUT -p tcp -m state --state NEW -m multiport --dports 
5634:6166  -j ACCEPT',
Line 205:         '#migration',
Line 206:         '-A INPUT -p tcp -m state --state NEW -m multiport --dports 
49152:49216 -j ACCEPT'


--
To view, visit http://gerrit.ovirt.org/8374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2fb5346eaf8c800952df28657df701911586faa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to