Juan Hernandez has posted comments on this change.
Change subject: packaging: cleanup _configIptables
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Did you consider using a cheetah template?
I also wonder why we still use that obsolete RH-Firewall-1-INPUT custom chain.
That was what the default firewall used in RHEL5. We could will use INPUT
directly to simplify things.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 919: lines.append(
Line 920: "-A RH-Firewall-1-INPUT -m state --state NEW -p
%s --dport %s -j ACCEPT" % (
Line 921: protocol,
Line 922: portNumber
Line 923: )
Do you know that in Pyhton you can do this?
values = { "port": 100, "protocol": "tcp" }
line = "-A ... -p %(protocol)s --dport %(port)d" % values
Line 924: )
Line 925:
Line 926: outputText = fileContent.replace('@CUSTOM_RULES@',
"\n".join(lines))
Line 927: logging.debug(outputText)
--
To view, visit http://gerrit.ovirt.org/8373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic08891752b537ea04c56e8aef2040cc5e89cbea3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
