Alon Bar-Lev has posted comments on this change.

Change subject: pki: use utc dates when communicating with openssl
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/setup/engine-setup.py
Line 751:             date = (
Line 752:                 datetime.datetime.utcnow() + datetime.timedelta(-1)
Line 753:             ).strftime(
Line 754:                 "%y%m%d%H%M%S+0000"
Line 755:             )
I don't like these extra variables... but your wish is my commands.
Line 756:             logging.debug("Date string is %s", date)
Line 757: 
Line 758:             # Add random string to certificate CN field
Line 759:             randInt = random.randint(10000,99999)


--
To view, visit http://gerrit.ovirt.org/8364
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I446bd9cc712b345bcf267bf6f5cd23dfc9fdea97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to