Yair Zaslavsky has posted comments on this change.
Change subject: engine:Cannot remove iscsi master storage right after removing
the storage pool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 179: for (VDS vds : vdss) {
Line 180:
StorageHelperDirector.getInstance().getItem(getStoragePool().getstorage_pool_type())
Line 181:
.DisconnectStorageFromDomainByVdsId(masterDomain, vds.getId());
Line 182: }
Line 183: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Is it ok that the removal from storage pool iso map occurs only for storages
that are not in LOCALFS? Maybe I missed it in the commit message -it wasn't
clear to me that this is one of the issues that you are solving.
Line 184: @Override
Line 185: public Void runInTransaction() {
Line 186: DbFacade.getInstance()
Line 187: .getStoragePoolIsoMapDao()
--
To view, visit http://gerrit.ovirt.org/8360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6b57cd772e6fb7b35b22972131331349a04c09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
