Daniel Erez has posted comments on this change. Change subject: core: introduce GetUnregisteredCinderDisksByStorageDomainIdQuery ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39650/5/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java: Line 215: * @param disks Line 216: * The result to check Line 217: */ Line 218: private static void assertFullGetAllAttachableDisksByPoolId(List<Disk> disks) { Line 219: assertEquals("There should be only three attachable disks", 4, disks.size()); > three vs 4 Done Line 220: Set<Guid> expectedFloatingDiskIds = Line 221: new HashSet<Guid>(Arrays.asList(FixturesTool.FLOATING_DISK_ID, FixturesTool.FLOATING_LUN_ID, Line 222: FixturesTool.FLOATING_CINDER_DISK_ID)); Line 223: Set<Guid> actualFloatingDiskIds = new HashSet<Guid>(); -- To view, visit https://gerrit.ovirt.org/39650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38c61f1763c4841101c199721414371acf101d59 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
