Eli Mesika has posted comments on this change. Change subject: construct jsonrpc with identifier name. ......................................................................
Patch Set 1: Code-Review-1 (6 comments) Patch includes unrelated changes , please rever and re-submit https://gerrit.ovirt.org/#/c/40315/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 123: --Handling Engine working mode Line 124: select fn_db_add_config_value('EngineMode','Active','general'); Line 125: --Handling Use Default Credentials Line 126: select fn_db_add_config_value('FailedJobCleanupTimeInMinutes','60','general'); Line 127: select fn_db_add_config_value('FenceAgentDefaultParams','ilo3:lanplus,power_wait=4;ilo4:lanplus,power_wait=4','general'); unrelated change , please revert Line 128: select fn_db_add_config_value('CustomFenceAgentDefaultParams','','general'); Line 129: select fn_db_add_config_value('FenceAgentDefaultParamsForPPC','ilo3:lanplus=1,cipher=1,privlvl=administrator,power_wait=4;ilo4:ilanplus=1,cipher=1,privlvl=administrator,power_wait=4;ipmilan:lanplus=1,cipher=1,privlvl=administrator,power_wait=4','general'); Line 130: select fn_db_add_config_value('CustomFenceAgentDefaultParamsForPPC','','general'); Line 131: select fn_db_add_config_value('FenceAgentMapping','drac7=ipmilan,ilo2=ilo,ilo3=ipmilan,ilo4=ipmilan','general'); Line 855: select fn_db_update_config_value('AutoRecoveryAllowedTypes','{\"storage domains\":\"true\",\"hosts\":\"true\"}','general'); Line 856: select fn_db_update_config_value('BootstrapMinimalVdsmVersion','4.9','general'); Line 857: select fn_db_update_config_value('DBEngine','Postgres','general'); Line 858: select fn_db_update_config_value('DefaultTimeZone','(GMT) GMT Standard Time','general'); Line 859: select fn_db_update_config_value('FenceAgentDefaultParams','ilo3:lanplus,power_wait=4;ilo4:lanplus,power_wait=4','general'); unrelated change , please revert Line 860: select fn_db_update_config_value('FenceAgentDefaultParamsForPPC','ilo3:lanplus=1,cipher=1,privlvl=administrator,power_wait=4,retry_on=2;ilo4:ilanplus=1,cipher=1,privlvl=administrator,power_wait=4,retry_on=2;ipmilan:lanplus=1,cipher=1,privlvl=administrator,power_wait=4,retry_on=2','general'); Line 861: select fn_db_update_config_value('FenceAgentMapping','drac7=ipmilan,ilo2=ilo,ilo3=ipmilan,ilo4=ipmilan','general'); Line 862: select fn_db_update_config_value('FenceStartStatusDelayBetweenRetriesInSec','10','general'); Line 863: select fn_db_update_config_value('FenceStartStatusRetries','18','general'); Line 873: -A INPUT -m state --state ESTABLISHED,RELATED -j ACCEPT Line 874: -A INPUT -p icmp -j ACCEPT Line 875: -A INPUT -i lo -j ACCEPT Line 876: # vdsm Line 877: -A INPUT -p tcp --dport @VDSM_PORT@ -j ACCEPT same here for the deleted lines Line 878: # SSH Line 879: -A INPUT -p tcp --dport @SSH_PORT@ -j ACCEPT Line 880: # snmp Line 881: -A INPUT -p udp --dport 161 -j ACCEPT Line 895: # gluster swift Line 896: -A INPUT -p tcp -m tcp --dport 8080 -j ACCEPT Line 897: Line 898: # portmapper Line 899: -A INPUT -p udp -m udp --dport 111 -j ACCEPT same Line 900: -A INPUT -p tcp -m tcp --dport 38465 -j ACCEPT Line 901: -A INPUT -p tcp -m tcp --dport 38466 -j ACCEPT Line 902: Line 903: # nfs Line 900: -A INPUT -p tcp -m tcp --dport 38465 -j ACCEPT Line 901: -A INPUT -p tcp -m tcp --dport 38466 -j ACCEPT Line 902: Line 903: # nfs Line 904: -A INPUT -p tcp -m tcp --dport 111 -j ACCEPT same Line 905: -A INPUT -p tcp -m tcp --dport 38467 -j ACCEPT Line 906: -A INPUT -p tcp -m tcp --dport 2049 -j ACCEPT Line 907: -A INPUT -p tcp -m tcp --dport 38469 -j ACCEPT Line 908: Line 1018: Line 1019: -- Reduce the host connection timeout from 180 seconds to 2 seconds and Line 1020: -- disable retries for more predictable HA timing: Line 1021: select fn_db_update_default_config_value('vdsConnectionTimeout', '180', '2', 'general', false); Line 1022: select fn_db_update_default_config_value('vdsRetries', '3', '0', 'general', false); same for removed lines Line 1023: Line 1024: ------------------------------------------------------------------------------------ Line 1025: -- Cleanup deprecated configuration values section Line 1026: ------------------------------------------------------------------------------------ -- To view, visit https://gerrit.ovirt.org/40315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1ce45d64db652ebf07ab3f81a3d9cf5a8a709d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Eldad Marciano <emarc...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
