Alona Kaplan has posted comments on this change. Change subject: webadmin: create VfsPopupWidget and init it with num of vfs ......................................................................
Patch Set 25: (3 comments) https://gerrit.ovirt.org/#/c/36260/25/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 4273: @DefaultStringValue("Virtual Functions (SR-IOV)") Line 4274: String vfsConfigTab(); Line 4275: Line 4276: @DefaultStringValue("Num of VFs setting") Line 4277: String numOfVfsSetting(); > "VF Settings"? It is not VF setting it is the setting just num of vfs setting. Changed to- "Number of VFs setting" Line 4278: Line 4279: @DefaultStringValue("Vfs Number") Line 4280: String numOfVfs(); Line 4275: Line 4276: @DefaultStringValue("Num of VFs setting") Line 4277: String numOfVfsSetting(); Line 4278: Line 4279: @DefaultStringValue("Vfs Number") > "VF Number"? Or "Number of VFs"? Done Line 4280: String numOfVfs(); https://gerrit.ovirt.org/#/c/36260/25/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/WebAdminGinUiBinderWidgets.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/WebAdminGinUiBinderWidgets.java: Line 3: import org.ovirt.engine.ui.common.gin.CommonGinUiBinderWidgets; Line 4: import org.ovirt.engine.ui.webadmin.section.main.view.popup.host.VfsConfigWidget; Line 5: Line 6: public interface WebAdminGinUiBinderWidgets extends CommonGinUiBinderWidgets { Line 7: VfsConfigWidget getVfsConfigWidget(); > Apologies for my ignorance, why is this helpful? In order to inject it using gin. Moved it to ClientGinjectorExtension which extends WebAdminGinUiBinderWidgets -- To view, visit https://gerrit.ovirt.org/36260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665b38a0d5a5df038216eae99364aa7afbcf2a23 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
