Alona Kaplan has posted comments on this change. Change subject: webadmin: Adding VfsConfigModel to HostNicModel ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/36258/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostNicModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostNicModel.java: Line 13: Line 14: public class HostNicModel extends Model { Line 15: Line 16: private final NicLabelModel labelsModel; Line 17: private VfsConfigModel vfsConfigModel = null; > No need to initialize a member to null. It is just a placeholder. In a future patch it is initiated with empty model- https://gerrit.ovirt.org/#/c/36260/30/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostNicModel.java Line 18: private VdsNetworkInterface iface; Line 19: Line 20: public NicLabelModel getLabelsModel() { Line 21: return labelsModel; https://gerrit.ovirt.org/#/c/36258/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigModel.java: Line 65: } Line 66: Line 67: private void initNetworks(List<Network> allClusterNetworks) { Line 68: Map<Guid, Network> clusterNetworksMap = createClusterNetworksMap(allClusterNetworks); Line 69: Set<Network> vfsConfigNetworks = new HashSet<>(); > I'm guessing you want this to be a SortedSet (according to network name) - The networks are already sorted. They are returned sorted from the backend query. Line 70: Line 71: for (Guid networkGuid : getEntity().getNetworks()) { Line 72: vfsConfigNetworks.add(clusterNetworksMap.get(networkGuid)); Line 73: } -- To view, visit https://gerrit.ovirt.org/36258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f2955d16287c291341646c76ebeaea9bbcb0aa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
