Maor Lipchuk has posted comments on this change. Change subject: core: introduce CloneCinderDisksCommand ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39644/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java: Line 26: case FAILED: Line 27: case FAILED_RESTARTED: Line 28: case UNKNOWN: Line 29: anyFailed = true; Line 30: log.error("Unknown command status."); It is not only unknown, it can be failed and failed restart also. you should simply print the commandStatus Line 31: break; Line 32: default: Line 33: log.error("Invalid command status: '{}", commandStatus); Line 34: break; -- To view, visit https://gerrit.ovirt.org/39644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b2e4b8c3f5a999303e45e8431809a276835c8ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
