Allon Mureinik has posted comments on this change. Change subject: core: Cleanup AuditLogableBase. ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java Line 499: public VmTemplateDAO getVmTemplateDao() { Line 500: return getDbFacade().getVmTemplateDao(); Line 501: } Line 502: Line 503: protected VmDAO getVmDAO() { what about this one? Line 504: return getDbFacade().getVmDao(); Line 505: } Line 506: Line 507: public VmStaticDAO getVmStaticDAO() { Line 503: protected VmDAO getVmDAO() { Line 504: return getDbFacade().getVmDao(); Line 505: } Line 506: Line 507: public VmStaticDAO getVmStaticDAO() { what about this one? Line 508: return getDbFacade().getVmStaticDao(); Line 509: } Line 510: Line 511: protected VmStatisticsDAO getVmStatisticsDao() { Line 535: public AdGroupDAO getAdGroupDao() { Line 536: return getDbFacade().getAdGroupDao(); Line 537: } Line 538: Line 539: protected VmNetworkInterfaceDAO getVmNetworkInterfaceDAO() { what about this one? Line 540: return getDbFacade().getVmNetworkInterfaceDao(); Line 541: } Line 542: Line 543: protected NetworkClusterDAO getNetworkClusterDao() { -- To view, visit http://gerrit.ovirt.org/8264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338cd7ad8dfe174e04c86a6f4cf32e29b6fcd374 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches