Kanagaraj M has posted comments on this change. Change subject: engine, webadmin: Check volume emptyness for geo-rep ......................................................................
Patch Set 7: Code-Review+1 > (2 comments) > > @Kanagaraj, > As Sahina said, if all slave nodes are down or slave volume is > down, session creation would fail and it is handled by the actions > such as mountbrokersetup in case of non-root user session else > update keys to slave session in case of root session. > > Removing this kind of volumes might not be possible with our > current approach of listing all volumes because we are using the > search query ,anyway we are showing the list of eligibility > criteria the a specific non-eligible volume DOES NOT MEET. > > I see the following 2 possibilities with our current approach: > 1. Handle this situation in UI if a specific set of critical errors > are present by disabling the create button. > 2. Create a query in the backend to return only those volumes which > ATLEAST satisfy a set of conditions if not all(for force case) > > I wish we could do these as a part of separate patch ;) :) as the > purpose of this patch WAS not that. > > @Sahina, @Kanagaraj : > Please let me know what you opine. And I will write an "all new > patch" for doing that. My concern here is, When the remote cluster hosts down, its not a recommendation violation. We need to remove this case from our recommendation checks. I am ok the current approach for now. We need to make this distinction more clear. -- To view, visit https://gerrit.ovirt.org/40153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia86df17975069d4fe7c1740bf609597fde7b08ac Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
