Alona Kaplan has posted comments on this change. Change subject: engine: introduce RefreshHostCommand ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/39892/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RefreshHostCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RefreshHostCommand.java: Line 16: } Line 17: Line 18: @Override Line 19: protected void executeCommand() { Line 20: VdsActionParameters vdsActionParams = new VdsActionParameters(getVdsId()); > s/vdsActionParams/parameters Done Line 21: if (!runInternalAction(VdcActionType.RefreshHostCapabilities, vdsActionParams).getSucceeded()) { Line 22: return; Line 23: } Line 24: Line 17: Line 18: @Override Line 19: protected void executeCommand() { Line 20: VdsActionParameters vdsActionParams = new VdsActionParameters(getVdsId()); Line 21: if (!runInternalAction(VdcActionType.RefreshHostCapabilities, vdsActionParams).getSucceeded()) { > Extracting the return value of the runInternalAction() will ease debug and Done Line 22: return; Line 23: } Line 24: Line 25: if (!runInternalAction(VdcActionType.RefreshHostDevices, vdsActionParams).getSucceeded()) { -- To view, visit https://gerrit.ovirt.org/39892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieee263b7ee1773c777febd6be21a1a21d0d02ae2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
