Alon Bar-Lev has posted comments on this change.

Change subject: extensions test tool: logger
......................................................................


Patch Set 26:

(1 comment)

https://gerrit.ovirt.org/#/c/37886/26/packaging/bin/ovirt-engine-extensions-tool.sh
File packaging/bin/ovirt-engine-extensions-tool.sh:

Line 29:        -Dorg.ovirt.engine.exttool.core.packageName="${PACKAGE_NAME}" \
Line 30:        
-Dorg.ovirt.engine.exttool.core.packageVersion="${PACKAGE_VERSION}" \
Line 31:        
-Dorg.ovirt.engine.exttool.core.packageDisplayName="${PACKAGE_DISPLAY_NAME}" \
Line 32:        -Dorg.ovirt.engine.exttool.core.engineEtc="${ENGINE_ETC}" \
Line 33:        -Dorg.ovirt.engine.exttool.core.defaultLogLevel="INFO" \
this should be in system environment not property, so people can override it...

OVIRT_LOG_LEVEL="ALL" ovirt-engine-extensions-tool ....
Line 34:        -jar "${JBOSS_HOME}/jboss-modules.jar" \
Line 35:        -dependencies org.ovirt.engine.core.extension-tool \
Line 36:        -class org.ovirt.engine.exttool.core.ExtensionsToolExecutor \


-- 
To view, visit https://gerrit.ovirt.org/37886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to