Maor Lipchuk has posted comments on this change. Change subject: core: Use ToStringBuilder in storage classes ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/39983/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenStackImageProviderProperties.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenStackImageProviderProperties.java: Line 12 Line 13 Line 14 Line 15 Line 16 Why removing this? https://gerrit.ovirt.org/#/c/39983/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/OpenStackVolumeProviderProperties.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/OpenStackVolumeProviderProperties.java: Line 52 Line 53 Line 54 Line 55 Line 56 Why removing this? https://gerrit.ovirt.org/#/c/39983/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java: Line 1: package org.ovirt.engine.core.common.vdscommands; Line 2: Line 3: import java.util.List; Not related to this patch Line 4: Line 5: import org.ovirt.engine.core.common.businessentities.StoragePool; Line 6: import org.ovirt.engine.core.common.businessentities.StoragePoolIsoMap; Line 7: import org.ovirt.engine.core.common.businessentities.VDS; https://gerrit.ovirt.org/#/c/39983/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMasterVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMasterVDSCommandParameters.java: Line 83: privateStoragePoolId = Guid.Empty; Line 84: privateMasterDomainId = Guid.Empty; Line 85: } Line 86: Line 87: private String getPrintableDomainsList() { probably better to change this also.. Line 88: StringBuilder sb = new StringBuilder(); Line 89: for (StoragePoolIsoMap map : getDomainsList()) { Line 90: sb.append("{ domainId: "); Line 91: sb.append(map.getstorage_id()); -- To view, visit https://gerrit.ovirt.org/39983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7787007a0cb30aa391ef3bddbecc997e81a76d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
