Maor Lipchuk has posted comments on this change. Change subject: core: introduce RegisterCinderDiskCommand ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39652/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RegisterCinderDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RegisterCinderDiskCommand.java: Line 32: public boolean canDoAction() { Line 33: CinderDisk cinderDisk = getCinderDisk(); Line 34: cinderDisk.setStorageIds(new ArrayList<>(Arrays.asList(getParameters().getStorageDomainId()))); Line 35: CinderDisksValidator cinderDiskValidator = getCinderDisksValidator(cinderDisk); Line 36: return validate(cinderDiskValidator.validateCinderDisksAlreadyRegistered()); > hmm, thought about it.. but why should we validate it instead of simply fai we actually do that, see ImportVmCommand#checkImagesGUIDsLegal Line 37: } Line 38: Line 39: @Override Line 40: public void executeCommand() { -- To view, visit https://gerrit.ovirt.org/39652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefb1ecf11d66039bbc4f5080b021b7393f27a0be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
