Maor Lipchuk has posted comments on this change. Change subject: core: introduce GetUnregisteredCinderDisksByStorageDomainIdQuery ......................................................................
Patch Set 3: (1 comment) Please add test for the DAO https://gerrit.ovirt.org/#/c/39650/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java: Line 178: try { Line 179: cinderDisk.setCreationDate(new SimpleDateFormat(DATE_FORMAT).parse(volume.getCreatedAt())); Line 180: } catch (ParseException e) { Line 181: cinderDisk.setCreationDate(null); Line 182: log.error("Invalid disk creation date format", e); Please also add the volume id of the disk Line 183: } Line 184: return cinderDisk; Line 185: } Line 186: -- To view, visit https://gerrit.ovirt.org/39650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38c61f1763c4841101c199721414371acf101d59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
