Maor Lipchuk has posted comments on this change. Change subject: core: adding cloneDisk to CinderBroker ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39642/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java: Line 96: cinderVolume.setSourceVolid(cinderDisk.getId().toString()); Line 97: return proxy.createVolume(cinderVolume); Line 98: } Line 99: }); Line 100: } > Since cloneDisk also requires 'setSourceVolid'. so not sure it worth the re You can simply add a parameter to the method API for sourceVolid, so create disk can also call it with null. Line 101: Line 102: public boolean isDiskExist(final Guid id) { Line 103: return execute(new Callable<Boolean>() { Line 104: @Override -- To view, visit https://gerrit.ovirt.org/39642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0de9529146ef02b63d0b61de1135f633389e47a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
