Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: deploy Cinder and Glance Docker containers ......................................................................
Patch Set 38: (5 comments) https://gerrit.ovirt.org/#/c/39519/38/packaging/setup/plugins/ovirt-engine-common/dockerc/core.py File packaging/setup/plugins/ovirt-engine-common/dockerc/core.py: Line 100: state=True, Line 101: ) Line 102: else: Line 103: raise RuntimeError( Line 104: _('Docker daemon is required to complete this setup') Why not simply set env[DOCKERCONSTS.CoreEnv.ENABLE] = False and that's it? If you install e.g. the allinone plugin, we ask if you want to setup vdsm, but do not force that. Same with websocket-proxy. Line 105: ) Line 106: Line 107: https://gerrit.ovirt.org/#/c/39519/38/packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py File packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py: Line 65: self.environment[ Line 66: odockerccons.RemoveEnv.REMOVE_DOCKERC Line 67: ] = dialog.queryBoolean( Line 68: dialog=self.dialog, Line 69: name='OVESETUP_REMOVE_ENGINE', YACPE (yet another copy paste error) ... OVESETUP_REMOVE_DOCKER? (Need to be fixed also elsewhere, we do need to note this somewhere) Line 70: note=_( Line 71: 'Do you want to remove the deployed ' Line 72: 'engine containers?\n' Line 73: 'Data will be lost\n' Line 68: dialog=self.dialog, Line 69: name='OVESETUP_REMOVE_ENGINE', Line 70: note=_( Line 71: 'Do you want to remove the deployed ' Line 72: 'engine containers?\n' "the Setup-deployed Docker containers?" or something like that? Perhaps also list them. Line 73: 'Data will be lost\n' Line 74: '(@VALUES@) [@DEFAULT@]: ' Line 75: ), Line 76: prompt=True, https://gerrit.ovirt.org/#/c/39519/38/packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py File packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py: Line 265: text=_( Line 266: 'The following containers were found:\n' Line 267: ' {found}\n' Line 268: 'Please remove or rename and ' Line 269: 'than execute Setup again\n' then :-) Line 270: ).format( Line 271: found=', '.join(already_existing), Line 272: ), Line 273: ) Line 457: ) Line 458: """, Line 459: args=dict( Line 460: provider_id=gpUUID, Line 461: provider_name=_('local-glance-image-repository'), I didn't refer to this one, only to the description. No idea what effect localizing also the name might have. We generally do not localize names. Line 462: provider_description=_( Line 463: 'Local Glance repository for oVirt' Line 464: ), Line 465: provider_url=( -- To view, visit https://gerrit.ovirt.org/39519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id192819a95343df9d9d035f8632d17ac76d2d82f Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
